[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library
Gheorghe-Teodor Bercea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 9 07:53:01 PST 2018
gtbercea added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:592
+ Twine("lib") + CLANG_LIBDIR_SUFFIX);
> Do you still need `.c_str()` here?
Doesn't compile without it but we can get there using Args.MakeArgString() also.
Comment at: test/Driver/openmp-offload-gpu.c:150
+/// bitcode library and add it to the LIBRARY_PATH.
+// RUN: touch %T/libomptarget-nvptx-sm_60.bc
+// RUN: env LIBRARY_PATH=%T %clang -### -fopenmp=libomp -fopenmp-targets=nvptx64-nvidia-cuda \
> grokos wrote:
> > ABataev wrote:
> > > Create empty `libomptarget-nvptx-sm_60.bc` in `Driver/lib` directory and use it in the test rather create|delete it dynamically.
> > I'm also in favour of this approach. On some systems /tmp is not accessible and the regression test fails.
> This test doesn't (and shouldn't!) use `/tmp`. The build directory and `%T` are always writable (if not, you have different issues on your system).
> Btw you need to pay attention that the driver now finds files next to the compiler directory. You may want to make sure that the test always passes / doesn't fail for wrong reasons.
Just added this.
More information about the cfe-commits