[PATCH] D44294: [clangd] Fix diagnostic errors in the test code, NFC.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 9 02:54:17 PST 2018


hokein added inline comments.


================
Comment at: unittests/clangd/XRefsTests.cpp:587
 
-  const char *HeaderContents = R"cpp([[]]int a;)cpp";
+  const char *HeaderContents = R"cpp([[]]#ifndef TEST_H_
+                                     #define TEST_H_
----------------
ilya-biryukov wrote:
> I would go with `#pragma once` in the test code, it adds less noise. WDYT?
I thought `#pragma once` is non-standard, but the diagnostic message also suggest this fix. Changed to it.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D44294





More information about the cfe-commits mailing list