[PATCH] D43494: [Modules] Fix creating fake definition data for lambdas.

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 8 15:57:41 PST 2018

rsmith added inline comments.

Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:1790
+    // set fake one.
+    D->DefinitionData = DD;
   ReadCXXDefinitionData(*DD, D);
I think it would make sense to "claim" the definition more eagerly here, by also updating `Canon->DefinitionData` in this case, prior to reading the definition data (and in the case where we already have a canonical definition, pointing `D->DefinitionData` at that eagerly).


More information about the cfe-commits mailing list