[PATCH] D44088: [clangd] Extract ClangdServer::Options struct.

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 8 04:12:00 PST 2018


jkorous-apple added inline comments.


================
Comment at: clang-tools-extra/trunk/clangd/ClangdServer.h:131
+  // Features like indexing must be enabled if desired.
+  static Options optsForTest();
+
----------------
Shouldn't this be better implemented as a utility function in tests?

Also what is the purpose of making global function in header file static?




Repository:
  rL LLVM

https://reviews.llvm.org/D44088





More information about the cfe-commits mailing list