[PATCH] D44217: [clang-tidy] Enable Python 3 support for add_new_check.py

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 8 03:26:54 PST 2018

ilya-biryukov added inline comments.

Comment at: clang-tools-extra/clang-tidy/add_new_check.py:24
   with open(filename, 'r') as f:
-    lines = f.readlines()
+    lines = [x for x in f.readlines()]
`readlines()` returns a list in Python3 too.
Maybe remove list comprehension?

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list