[PATCH] D44189: [RISCV] Verify the input value of -march=

Kito Cheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 7 23:40:05 PST 2018

kito-cheng marked 2 inline comments as done.
kito-cheng added inline comments.

Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:48
+      break;
+    default:
+      // First letter should be 'i' or 'g'.
apazos wrote:
> In the switch cases move default to first position.
Done :)

Comment at: lib/Driver/ToolChains/Arch/RISCV.cpp:60
       case 'm':
apazos wrote:
> So the subsequent features can appear in any order?
Yeah, here is a canonical order specified in ISA manual, I've check the order now.

  rC Clang


More information about the cfe-commits mailing list