[PATCH] D44223: [ms] Emit vtordisp initializers in a deterministic order.

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 7 13:57:34 PST 2018

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.


Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1207
     uint64_t ConstantVBaseOffset =
-        Layout.getVBaseClassOffset(I->first).getQuantity();
+        Layout.getVBaseClassOffset(VBase).getQuantity();
The `getVBaseClassOffset` call turns around and does the same hashtable lookup we just did. Let's keep the iterator around and say `I->second.VBaseOffset.getQuantity()`.


More information about the cfe-commits mailing list