[PATCH] D44173: [clang-tidy] Add "portability" module and rename readability-simd-intrinsics to portability-simd-intrinsics

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 6 14:14:34 PST 2018

lebedev.ri added a comment.

I should have seen in during the initial review, but better now than never, right? :)

Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.cpp:141
   if (!New.empty()) {
     std::string Message;
     // If Suggest is true, give a P0214 alternative, otherwise point it out it
Here too, surely some sane static size can be picked?

Comment at: clang-tidy/portability/SIMDIntrinsicsCheck.h:32
+  std::string Std;
   const bool Suggest;
This could be `llvm::SmallString<32> Std;`, actually. (or `strlen("std::experimental")`)

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list