[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 6 12:27:18 PST 2018

juliehockett added inline comments.

Comment at: clang-doc/BitcodeReader.cpp:19
+void ClangDocBitcodeReader::storeData(llvm::SmallString<4> &Field,
+                                      llvm::StringRef Blob) {
lebedev.ri wrote:
> I think all these `SmallString` can be one `llvm::SmallVectorImpl<char>`?
No, since there's not an implicit converter from `llvm::SmallVectorImpl<char>` to `StringRef`. I templatized it on the size though, so it's only one function now.

Comment at: clang-doc/Representation.h:193
+ private:
+  void resolveReferences(llvm::SmallVector<Reference, 4> &References,
+                         Reference &Caller);
lebedev.ri wrote:
> Similarly, i think those should be `SmallVectorImpl` (i assume those are output params, too?)
Yup -- the pointer inside gets set.


More information about the cfe-commits mailing list