[PATCH] D44093: [BUILTINS] structure pretty printer

[Paul Semel via Phabricator via cfe-commits]

paulsemel marked 4 inline comments as done.
paulsemel added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:1208
+
+    assert(RT && "The first argument must be a record type");
+
----------------
aaron.ballman wrote:
> I don't see anything enforcing this constraint, so users are likely to hit this assertion rather than a compile error.
I actually didn't manage to enforce this in the builtin declaration as we can only declare simple types (I am probably missing something)


================
Comment at: lib/CodeGen/CGBuiltin.cpp:1258
+
+      //Need to handle bitfield here
+
----------------
aaron.ballman wrote:
> Are you intending to implement this as part of this functionality?
Yes, my goal is to be able to dump the bitfields correctly, particularly if the structure is packed (for dumping a GDT for example).
I just didn't manage to do it properly for the moment.


Repository:
  rC Clang

https://reviews.llvm.org/D44093