[PATCH] D44100: [ASTImporter] Reorder fields after structure import is finished

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 6 01:50:29 PST 2018

a.sidorin added a comment.

Hi Gabor,

> Just a minor high level note. If https://reviews.llvm.org/D32947 will be accepted once, we will need to reorder friends as well. Or alternatively, we have to omit the check of friends in structural equivalence in https://reviews.llvm.org/D32947.

I'd prefer to land https://reviews.llvm.org/D32947 before the fix for friend decls reordering so we will have a subject for testing. And the fix for friend decls can become a separate patch. Do you already have such patch or a test for the issue?

  rC Clang


More information about the cfe-commits mailing list