[PATCH] D41316: [libcxx] Allow random_device to be built optionally

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 5 11:04:12 PST 2018

Quuxplusone added inline comments.

Comment at: test/std/numerics/rand/rand.device/lit.local.cfg:1
+# Disable all of the random device tests if the correct feature is not available.
+if 'libcpp-has-no-random-device' in config.available_features:
EricWF wrote:
> There are only 3 tests under this directory. I would rather mark each one explicitly with `// UNSUPPORTED: libcpp-has-no-random-device`
@weimingz: looks like this request from Eric is unresolved.

FWIW: I'm still ambivalent about the whole direction of this patch; but I'm happy if everyone else is happy. I don't anticipate any new comments from me.


More information about the cfe-commits mailing list