[PATCH] D25820: [Sema][Objective-C] Formatting warnings should see through Objective-C message sends

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 5 08:32:05 PST 2018

aaron.ballman added a comment.

In https://reviews.llvm.org/D25820#1027216, @benhamilton wrote:

> Actually, looking more deeply, it's possible this is a bug in the Apple SDK:
>   @interface NSBundle
>   - (NSString *)localizedStringForKey:(NSString *)key value:(nullable NSString *)value table:(nullable NSString *)tableName __attribute__((format_arg(1)));
>   @end
> Since `format_arg(X)` is 1-based, and `value` is the format param here, I wonder if this shouldn't be `__attribute__((format_arg(2))`.

That does look like a bug in the SDK, to me.



More information about the cfe-commits mailing list