[PATCH] D43197: [OpenMP] Add flag for linking runtime bitcode library

Gheorghe-Teodor Bercea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 5 07:45:01 PST 2018

gtbercea added inline comments.

Comment at: lib/Driver/ToolChains/Cuda.cpp:536-542
+      StringRef CompilerPath = env;
+      while (!CompilerPath.empty()) {
+        std::pair<StringRef, StringRef> Split =
+            CompilerPath.split(llvm::sys::EnvPathSeparator);
+        LibraryPaths.push_back(Split.first);
+        CompilerPath = Split.second;
+      }
Hahnfeld wrote:
> `tools::addDirectoryList` uses `StringRef::find`, I'm not sure if `StringRef::split` creates real copies of the string...
What is your suggestion?

  rC Clang


More information about the cfe-commits mailing list