[PATCH] D44003: [clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 5 01:53:58 PST 2018

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM, but note the unreachable code comment

Comment at: unittests/clangd/FuzzyMatchTests.cpp:35
+  friend raw_ostream &operator<<(raw_ostream &OS, const ExpectedMatch &M) {
+    return OS << "'" << M.Word;
Maybe put operator before `Word` to keep fields grouped together?

Comment at: unittests/clangd/FuzzyMatchTests.cpp:37
+    return OS << "'" << M.Word;
+    if (M.Annotated)
+      OS << "' as " << *M.Annotated;
This code is unreachable. Probably intended to remove `return`  from the previous line?

  rCTE Clang Tools Extra


More information about the cfe-commits mailing list