[PATCH] D41102: Setup clang-doc frontend framework

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 2 11:04:31 PST 2018


juliehockett added inline comments.


================
Comment at: clang-doc/Representation.h:117
+  bool IsDefinition = false;
+  llvm::Optional<Location> DefLoc;
+  llvm::SmallVector<Location, 2> Loc;
----------------
lebedev.ri wrote:
> I meant that `IsDefinition` controls whether `DefLoc` will be set/used or not.
> So with `llvm::Optional<Location> DefLoc`, you don't need the `bool IsDefinition`.
That...makes so much sense. Oops. Thank you!


https://reviews.llvm.org/D41102





More information about the cfe-commits mailing list