[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

ahedberg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 2 06:43:11 PST 2018


ahedberg added a comment.

In https://reviews.llvm.org/D43847#1024018, @aaron.ballman wrote:

> In https://reviews.llvm.org/D43847#1023452, @hokein wrote:
>
> > In https://reviews.llvm.org/D43847#1021967, @aaron.ballman wrote:
> >
> > > I need a bit more context because I'm unfamiliar with `absl`. What is this module's intended use?
> >
> >
> > As `absl` has been open-sourced (https://github.com/abseil/abseil-cpp), I think there will be more absl-related checks contributed from google or external contributors in the future, so it make sense to create a new module.
>
>
> Ah, so this is for abseil, good to know. Yeah, I think we should have a new module for it but perhaps with the full name instead of this shortened version?


+1 to the name `abseil`. Some folks from the Abseil team discussed yesterday--we want to keep other projects from using nested absl namespaces to avoid ever having to type ::absl. So it would be nice to replace that nested namespace with something else; maybe clang::tidy::abseil?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43847





More information about the cfe-commits mailing list