[PATCH] D43248: [Attr] Fix parameter indexing for attributes

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In https://reviews.llvm.org/D43248#1023720, @jdenny wrote:

> Hi Aaron.  It occurs to me now that this patch has grown rather large and, in some places, a little subtle.  Would it help the review if I were to break it up into a patch series that introduces ParamIdx to each attribute, one at a time?  I'm not trying to rush you, but I hate for the review to be painful for you if it doesn't have to be.


No need to do that -- this review just takes a bit more time for me to complete, but it's reasonably well-factored. Thank you, though!


https://reviews.llvm.org/D43248