[PATCH] D43248: [Attr] Fix parameter indexing for attributes

Joel E. Denny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 1 07:41:18 PST 2018


jdenny added a comment.

Hi Aaron.  It occurs to me now that this patch has grown rather large and, in some places, a little subtle.  Would it help the review if I were to break it up into a patch series that introduces ParamIdx to each attribute, one at a time?  I'm not trying to rush you, but I hate for the review to be painful for you if it doesn't have to be.


https://reviews.llvm.org/D43248





More information about the cfe-commits mailing list