[PATCH] D43852: [OpenMP] Extend NVPTX SPMD implementation of combined constructs

[Alexey Bataev via Phabricator via cfe-commits]

ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG, with some nits



================
Comment at: include/clang/Driver/Options.td:1428
+def fopenmp_cuda_mode : Flag<["-"], "fopenmp-cuda-mode">, Group<f_Group>, Flags<[CC1Option, NoArgumentUnused]>;
+def fno_openmp_cuda_mode : Flag<["-"], "fno-openmp-cuda-mode">, Group<f_Group>, Flags<[NoArgumentUnused]>;
 def fno_optimize_sibling_calls : Flag<["-"], "fno-optimize-sibling-calls">, Group<f_Group>;
----------------
This flag also must be `CC1Option`


================
Comment at: lib/Frontend/CompilerInvocation.cpp:2533
+      Args.hasFlag(OPT_fopenmp_cuda_mode, OPT_fno_openmp_cuda_mode,
+                   /*Default=*/false);
+
----------------
After some thoughts I think it is better to make `true` by default, because `Generic` mode is not completed yet.


Repository:
  rC Clang

https://reviews.llvm.org/D43852