[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 27 03:27:16 PST 2018


alexfh added inline comments.


================
Comment at: clang-tidy/modernize/MakeSharedCheck.h:38
+
+  bool isVersionSupported(const clang::LangOptions &LangOpts) const override;
 };
----------------
1. s/clang:://
2. it's not clear which "version" is this all about. I'd suggest isLanguageSupported/isLanguageVersionSupported or something else more specific than just "version".


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43766





More information about the cfe-commits mailing list