[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 27 02:52:35 PST 2018


hokein added a comment.

Thanks for the patch!

The check provides `MakeSmartPtrFunction` option. Users can use it to customize their self-implemented `make_unique` function (instead of using the c++14 available `std::make_unique`) even in their C++11 code. I think we need to keep the backward compatibility.

I'd suggest only checking the C++14 flag when the suggested fix is "std::make_unique".


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43766





More information about the cfe-commits mailing list