[PATCH] D43780: [Tooling] [1/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 26 12:48:13 PST 2018


lebedev.ri created this revision.
lebedev.ri added reviewers: klimek, bkramer, alexfh, pcc.
lebedev.ri added projects: clang, clang-tools-extra.
Herald added subscribers: jkorous-apple, ioeric.

I'm not sure whether there are any principal reasons why it returns raw owning pointer,
or it is just a old code that was not updated post-C++11.

I'm not too sure what testing i should do, because `check-all` is not error clean here for some reason,
but it does not //appear// asif those failures are related to these changes.

This is Clang-tools-extra part.
Clang part is https://reviews.llvm.org/D43779.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43780

Files:
  clang-move/ClangMove.h
  clang-tidy/ClangTidy.cpp
  clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
  include-fixer/find-all-symbols/FindAllSymbolsAction.h
  modularize/CoverageChecker.cpp
  modularize/Modularize.cpp
  pp-trace/PPTrace.cpp
  unittests/clang-tidy/ClangTidyTest.h
  unittests/clangd/SymbolCollectorTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43780.135956.patch
Type: text/x-patch
Size: 6590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180226/1aebb3ab/attachment.bin>


More information about the cfe-commits mailing list