[PATCH] D43547: [Indexing] Fixing inconsistencies between FUNCDNAME and generated code by improving ASTContext's API for MangleContext

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

Code looks good, but we should test it. Can you add a CodeGenCXX test that shows the issue with FUNCDNAME? I see the issue with this program:

  #include <stdio.h>
  int main() {
    const char *s1 = ([]() { return __FUNCDNAME__; })();
    const char *s2 = ([]() { return __FUNCDNAME__; })();
    printf("%s\n%s\n", s1, s2);
  }



================
Comment at: lib/AST/Expr.cpp:500-502
+      MangleContext& MC = Context.getMangleContext();
 
+      if (MC.shouldMangleDeclName(ND)) {
----------------
Oh, I see, FUNCDNAME was really broken. Ignore my previous comment.


https://reviews.llvm.org/D43547