[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

Simon Dardis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 26 07:43:03 PST 2018


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D43585#1017957, @bsdjhb wrote:

> My only question is if this should be named LIBUNWIND_TEST_COMPILER_FLAGS to match the name used in libc++?


I would say yes for the sake of consistency with the option it's controls and libcxx. Additionally, we also require config.test_linker_flags to be set as well, so we need LIBUNWIND_LINKER_FLAGS.

LGTM with those two additional changes. I've tested it with your N32 patch and it works.


Repository:
  rUNW libunwind

https://reviews.llvm.org/D43585





More information about the cfe-commits mailing list