[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 25 11:37:59 PST 2018


aaron.ballman added a comment.

In general, I think the idea is reasonable, but in practice I'm worried about the attributes with custom parsing. Sometimes the parsing requires those extra bits and I'm not certain of how best to address that.



================
Comment at: test/Misc/ast-print-objectivec.m:52
 // CHECK: @class C1;
-// CHECK: struct __attribute__((objc_bridge_related(C1, , ))) S1;
+// CHECK: struct __attribute__((objc_bridge_related(C1))) S1;
----------------
This fix is incorrect in this case -- the attribute doesn't parse without the extra commas.

https://godbolt.org/g/Ze69HD


https://reviews.llvm.org/D43748





More information about the cfe-commits mailing list