[PATCH] D43667: [clang-doc] Implement a YAML generator

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 23 10:36:03 PST 2018


Eugene.Zelenko added a comment.

I may be mistaken, but Clang source code didn't use llvm namespace by default. Insetad you should include clang/Basic/LLVM.h and use llvm:: for rest of things.



================
Comment at: clang-doc/tool/ClangDocMain.cpp:42
 
 namespace {
 
----------------
There is no need to enclose static definitions in anonymous namespace.


https://reviews.llvm.org/D43667





More information about the cfe-commits mailing list