[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang-tidy/google/GlobalVariableDeclarationCheck.cpp:92
+         "an appropriate prefix (see "
+         "http://google.github.io/styleguide/objcguide#constants).")
         << Decl->getName() << generateFixItHint(Decl, true);
----------------
We don't usually put hyperlinks in the diagnostic messages, so please remove this.

My suggestion about describing what constitutes an appropriate prefix was with regards to the style guide wording itself. For instance, that document doesn't mention that two capital letters is good. That's not on you to fix before this patch goes in, of course.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43581