[PATCH] D43581: [clang-tidy/google] Fix the Objective-C global variable declaration check 🔧

Yan Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 22 11:41:53 PST 2018


Wizard accepted this revision.
Wizard added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D43581#1016318, @stephanemoore wrote:

> In https://reviews.llvm.org/D43581#1016300, @Wizard wrote:
>
> > Please update the warning info to indicate that prefix 'k' is not the only option for constants. Something like:
> >  "const global variable '%0' must have an appropriate prefix or a name which starts with 'k[A-Z]'"
>
>
> Is the latest warning info satisfactory? I believe I updated it after adding you as a reviewer.


Hmm I feel it is a bit unfriendly to show users a rather complicated regex in the info, but I will leave it to you. Not a big problem.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43581





More information about the cfe-commits mailing list