[PATCH] D43569: [clangd] Correct setting ignoreWarnings in CodeCompletion.

[Haojian Wu via Phabricator via cfe-commits]

hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clangd/CodeComplete.cpp:705
   }
+  CI->getDiagnosticOpts().IgnoreWarnings = true;
   auto Clang = prepareCompilerInstance(
----------------
ilya-biryukov wrote:
> Could we add a comment that this should be done before calling `prepareCompilerInstance`?
> I'm afraid this can be accidentally reordered when changing the code.
Yeah! Done.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43569