[PATCH] D41102: Setup clang-doc frontend framework

Julie Hockett via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Feb 18 23:05:49 PST 2018


juliehockett added inline comments.


================
Comment at: clang-doc/ClangDocBinary.cpp:88
+  Stream.Emit((unsigned)'C', 8);
+  Stream.Emit((unsigned)'S', 8);
+}
----------------
lebedev.ri wrote:
> General comment: shouldn't the bitcode be versioned?
Possibly? My understanding of the versioning (which could be incorrect) was that it was for the LLVM IR and how it is written in the given file -- I'm not writing to LLVM IR here, just using it as a data storage format, and so didn't think it was necessary. Happy to add it in though, but which version number should I use?


https://reviews.llvm.org/D41102





More information about the cfe-commits mailing list