[PATCH] D43378: FreeBSD driver / Xray flags moving pthread to compile flags.

Ed Maste via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 16 11:04:39 PST 2018


emaste added a comment.

LGTM with one small note.

What will it take for us to enable this on the rest of the platforms Clang/FreeBSD supports?



================
Comment at: test/Driver/XRay/lit.local.cfg:7-8
 supported_targets = [
     'x86_64', 'x86_64h', 'arm', 'aarch64', 'arm64', 'powerpc64le', 'mips',
-    'mipsel', 'mips64', 'mips64el'
+    'mipsel', 'mips64', 'mips64el', 'amd64'
 ]
----------------
Minor quibble, probably worth grouping `amd64` with `x86_64`, as `aarch64` and `arm64` are.


https://reviews.llvm.org/D43378





More information about the cfe-commits mailing list