[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

[Gábor Horváth via Phabricator via cfe-commits]

xazax.hun added a comment.

In https://reviews.llvm.org/D30691#1003514, @george.karpenkov wrote:

> Python code looks OK to me, I have one last request: could we have a small documentation how the whole thing is supposed work in integration, preferably on an available open-source project any reader could check out?
>  I am asking because I have actually tried and failed to launch this CTU patch on a project I was analyzing.


We added the documentation. Could you recheck? Thanks in advance!



================
Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:395
+    return XFE && !YFE;
+  return XFE->getName() < YFE->getName();
+}
----------------
nikhgupt wrote:
> getName could yield incorrect results if two files in the project have the same name. This might break the assert for PathDiagnostics 'total ordering' and 'uniqueness'.
> Maybe replacing FileEntry's getName with FullSourceLoc's getFileID could resolve this.
Thank you, this is a known problem that we plan to address in a follow-up patch.


https://reviews.llvm.org/D30691