[PATCH] D38639: [clangd] #include statements support for Open definition

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM modulo the `ASSERT_TRUE` nit.



================
Comment at: unittests/clangd/XRefsTests.cpp:295
+      runFindDefinitions(Server, FooCpp, SourceAnnotations.point());
+  EXPECT_TRUE(bool(Locations)) << "findDefinitions returned an error";
+  EXPECT_THAT(Locations->Value,
----------------
Maybe replace with `ASSERT_TRUE`?
If `Locations` has an error, an assertion will fire in debug mode inside `Expected` that the error was not handled.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D38639