[PATCH] D43240: [OpenCL] Fix __enqueue_block for block with captures
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Feb 15 06:48:18 PST 2018
yaxunl added a comment.
In https://reviews.llvm.org/D43240#1008560, @Anastasia wrote:
> LGTM! Thanks for looking at this. Just one thing, I was wondering whether it would be cleaner way if we extend test/CodeGenOpenCL/cl20-device-side-enqueue.cl instead of adding a new one here? Because this is the test that is meant to exercise all DSE codegen bits. Perhaps we can modify one block in that test to have the same format as here (i.e. using captures), since now we test the same block there most of the time. However, we don't test any of kernel wrapper `*_block_invoke_kernel` there. Not sure why...
We do check block wrappers in cl20-device-side-enqueue.cl, which is done at the end of the test.
I did not add this test to cl20-device-side-enqueue.cl because cl20-device-side-enqueue.cl is already very complicated. I can add this test to cl20-device-side-enqueue.cl when committing.
https://reviews.llvm.org/D43240
More information about the cfe-commits
mailing list