[PATCH] D10831: Attach attribute "trap-func-name" to IR function

Eric Christopher via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 14 19:13:20 PST 2018


It could, but then you'd need to change every front end to have the same
sort of behavior, maybe you want to configure it differently, etc.

That said, I really have no strong opinions here :)

-eric

On Wed, Feb 14, 2018 at 6:51 PM Peter Collingbourne via Phabricator <
reviews at reviews.llvm.org> wrote:

> pcc added a comment.
> Herald added subscribers: llvm-commits, mehdi_amini.
>
> Maybe I'm missing something, but I don't see why we need this attribute.
> Couldn't clang have been changed to implement `-ftrap-function` by
> generating a call to the trap function instead of emitting an `llvm.trap`
> intrinsic call?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D10831
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180215/954a43a8/attachment.html>


More information about the cfe-commits mailing list