[PATCH] D43259: Implement function attribute artificial

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 13 15:18:20 PST 2018


rnk accepted this revision.
rnk added subscribers: probinson, aprantl, dblaikie.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

---

Clang's builtin headers use `__attribute__((__nodebug__))` for this purpose. Do you think we should follow this up by using artificial instead? It seems like it would be a representational improvement. @aprantl @probinson @dblaikie



================
Comment at: test/Sema/artificial.c:3
+
+void __attribute__((artificial)) bar() {} // expected-warning {{'artificial' attribute only applies to inline functions}}
----------------
I think it's worth adding the `foo` function from the CodeGen test here to show we don't generate warnings when the function is inline specified.


https://reviews.llvm.org/D43259





More information about the cfe-commits mailing list