[PATCH] D43246: [clangd] Assert path is absolute when assigning to URIForFile.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 13 10:31:10 PST 2018


ioeric added a comment.

I think another option to prevent the bug in r325029 from happening would be providing a canonical approach for retrieving (absolute) paths from `FileManager`. We already have code in symbol collector that does this, and we have similar code in XRefs.cpp now. We should probably move them to `clangd/Path.h` and share the code?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43246





More information about the cfe-commits mailing list