[PATCH] D43230: [clangd] Explicitly initialize all primitive fields in Protocol.h

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 13 03:52:52 PST 2018


ioeric added a comment.

I think it's useful to explicit initialize non-trivial types like `FileChangeType`. But I think it's safe and probably easier to rely on default values of primitive types like int, bool etc. Explicitly setting default values is probably fine (so this change LGTM), but do we really want to make this a requirement for future changes or even in our coding style?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43230





More information about the cfe-commits mailing list