[PATCH] D42923: [CUDA] Allow external variables in separate compilation

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 12 11:51:26 PST 2018


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: test/SemaCUDA/extern-shared.cu:4
+// These declarations are fine in separate compilation mode!
+// RUN: %clang_cc1 -fsyntax-only -fcuda-rdc -verify=rdc %s
+// RUN: %clang_cc1 -fsyntax-only -fcuda-is-device -fcuda-rdc -verify=rdc %s
----------------
Nit. `-verify=rdc` is somewhat confusing as there's no rdc prefixes in the checks below. Perhaps something along the lines of `-verify=there-should-be-no-errors`  would be more descriptive.


Repository:
  rC Clang

https://reviews.llvm.org/D42923





More information about the cfe-commits mailing list