[PATCH] D43123: [clangd] Log all ignored diagnostics.

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clangd/ClangdUnit.cpp:197
-
-    log(llvm::formatv("Ignored diagnostic outside main file. {0}: {1}",
-                      Location, Message));
----------------
hokein wrote:
> I'm not sure, do we care about this particular case (diagnostic outside main file)? With the new change, we don't know whether the diag is from main file or outside main file。
We probably don't.
We output the location of the diagnostic anyway, so there should always be enough context when looking at the logs.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43123