[PATCH] D43045: Add NVPTX Support to ValidCPUList (enabling march notes)

[Artem Belevich via Phabricator via cfe-commits]

tra added inline comments.


================
Comment at: test/Misc/target-invalid-cpu-note.c:38
+// NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
+// NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72
----------------
erichkeane wrote:
> tra wrote:
> > Nit: Generally speaking this note is false. For any given version of CUDA, some of the listed GPU variants will not be accepted. E.g. CUDA versions before 9.1 do not know anything about sm_72, but CUDA-9.1  does not supports sm_20. 
> Is there somewhere else that this is checked?  It seems that the 'setCPU' function here checks against this same list.  
We have CheckCudaVersionSupportsArch() in lib/Driver/ToolChains/Cuda.cpp.
I'm not sure if CUDA version is already known at the time we check -target-cpu, though.

I'm OK with the ful list for now if it's hard to get to the CUDA version.




https://reviews.llvm.org/D43045