[PATCH] D43068: [clangd] Remove codeComplete that returns std::future<>

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 8 06:50:54 PST 2018


ioeric added inline comments.


================
Comment at: unittests/clangd/SyncAPI.h:8
+//
+//===---------------------------------------------------------------------===//
+#ifndef LLVM_CLANG_TOOLS_EXTRA_UNITTESTS_CLANGD_SYNCAPI_H
----------------
Any reason not to put sync APIs in ClangdServer by their async versions, so that they are easier to find? I might be missing context. But if there is a good reason, please explain in the file doc.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D43068





More information about the cfe-commits mailing list