[PATCH] D42561: [PR36008] Avoid -Wsign-compare warning for enum constants in typeof expressions

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 6 04:49:37 PST 2018


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM, aside from a minor commenting nit.



================
Comment at: lib/Sema/SemaChecking.cpp:8960
+    // Avoid warning about comparison of integers with different signs when
+    // RHS/LHS has a `typeof(E)` type whose sign is different to the sign of the
+    // type of `E`.
----------------
to the sign -> from the sign


https://reviews.llvm.org/D42561





More information about the cfe-commits mailing list