[PATCH] D42919: [clangd] Support simpler JSON-RPC stream parsing for lit tests.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Feb 6 02:48:28 PST 2018


sammccall marked an inline comment as done.
sammccall added a comment.

In https://reviews.llvm.org/D42919#998695, @ioeric wrote:

> LGTM
>
> Have we kept a lit test that uses content-length? It's unclear from the patch.


Yes, `protocol.test` tests the real protocol parser. (The other tests that use this parser are are `too_large`, which i'll merge with protocol, and `input_mirror`, which i'll cut down a little bit, as followup)



================
Comment at: clangd/tool/ClangdMain.cpp:89
+static llvm::cl::opt<bool> Test(
+    "test",
+    llvm::cl::desc(
----------------
ioeric wrote:
> To be more specific, maybe `--lit-test-mode`?
changed to `--lit-test`. ("mode" seems redundant in a flag name?)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D42919





More information about the cfe-commits mailing list