[PATCH] D42887: [Driver] Add option to manually control discarding value names in LLVM IR.

[Eric Fiselier via Phabricator via cfe-commits]

EricWF marked an inline comment as done.
EricWF added inline comments.


================
Comment at: lib/Driver/ToolChains/Clang.cpp:3269
 
-// Disable the verification pass in -asserts builds.
+  const bool IsAssertBuild =
 #ifdef NDEBUG
----------------
lebedev.ri wrote:
> This logic seems sidewards.
> If `NDEBUG` is specified, then it is `assert()`-less build.
> If `NDEBUG` is *not* specified, then `assert()`'s are actually functional.
> 
Woops! Silly me. Thats a dumb mistake and I feel dumb having made it.


https://reviews.llvm.org/D42887