[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 2 11:09:26 PST 2018


erichkeane added inline comments.


================
Comment at: lib/AST/MicrosoftMangle.cpp:1717
+        Out << '8';
+        for (const char *NS : {"__swift_cc", "__Swift"})
+          mangleSourceName(NS);
----------------
When I implemented regcall, it was brought up that this was likely a bad idea, and to just choose a letter for mangleCallingConvention.  It is a really stable list as it is, and if you avoid ones in the immediate pattern, you'll be fine.


Repository:
  rC Clang

https://reviews.llvm.org/D42768





More information about the cfe-commits mailing list