[PATCH] D42755: [libcxx] Fix last_write_time tests for filesystems that don't support very small times.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 1 15:14:15 PST 2018


vsapsai added a comment.

In https://reviews.llvm.org/D42755#994775, @Hahnfeld wrote:

> Can you please add a summary that describes which filesystem this problem can be seen with? I think outside people can't access rdar tickets, so I can only guess that it's related to APFS? Further guessing the filesystem supports negative timestamps in general but not `file_time_type::min()` (which probably is `-2 ** 63`)?


Good suggestion for explaining the problem with `file_time_type::min()` in more detail. Also PR35990 <https://bugs.llvm.org/show_bug.cgi?id=35990> has some details on how different filesystems handle `file_time_type::min()`. As the change doesn't fix the PR, I don't think it is worth mentioning it in the commit message but it can be still useful in code review discussion.


https://reviews.llvm.org/D42755





More information about the cfe-commits mailing list