[PATCH] D42785: [Analyzer] Fix a typo in `ExprEngine::VisitMemberExpr`

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 1 11:10:51 PST 2018


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Ew. So it means that checker transitions are currently discarded. Great catch. I guess we don't use this functionality yet, so we can't test it, but the fix should definitely go in.

Then, again, i'm suspecting that you may want to use `checkLocation` or `checkBind` instead of `checkPreStmt<MemberExpr>` - i doubt that there's anything special about member expressions that make them different from other sorts of bindings. And if you're tracking how a symbol is assigned to a field of the structure - well, you shouldn't, this info is already in the program state and you can retrieve it any time with `getSVal(Region)`.


Repository:
  rC Clang

https://reviews.llvm.org/D42785





More information about the cfe-commits mailing list