[PATCH] D42729: clang-format: Fix formatting of function body followed by semicolon

Daniel Jasper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 1 06:59:31 PST 2018


djasper added a comment.

- Of course you find all sorts of errors while testing clang-format on a large-enough codebase. That doesn't mean that users run into them much.
- We have had about 10k clang-format users internally for several years. The semicolon issue comes up but really rarely and if it does, people happily fix their code not blaming clang-format.

Unrelated, my point remains that setting BlockKind in TokenAnnotator is bad enough that I wouldn't want to do it for reaping this small benefit. And I can't see how you could easily achieve the same thing without doing that.


Repository:
  rC Clang

https://reviews.llvm.org/D42729





More information about the cfe-commits mailing list